Issue 195563003: Increase Dart based command line analyzer cache size to 512.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195563003: Increase Dart based command line analyzer cache size to 512. (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
clayberg, danrubel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Increase Dart based command line analyzer cache size to 512. R=danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33554

Patch Set 2 : Really inscrease to 512 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/analyzer_impl.dart	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
	M	tests/language/language_analyzer2.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

clayberg

https://codereview.chromium.org/195563003/diff/1/pkg/analyzer/lib/src/analyzer_impl.dart File pkg/analyzer/lib/src/analyzer_impl.dart (right): https://codereview.chromium.org/195563003/diff/1/pkg/analyzer/lib/src/analyzer_impl.dart#newcode24 pkg/analyzer/lib/src/analyzer_impl.dart:24: const int _MAX_CACHE_SIZE = 256; 256 or 512?

6 years, 9 months ago (2014-03-11 20:23:15 UTC) #2

scheglov

6 years, 9 months ago (2014-03-11 20:29:25 UTC) #3

scheglov

6 years, 9 months ago (2014-03-11 21:08:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33554 (presubmit successful).

Expand Messages | Collapse Messages

Issue 195563003: Increase Dart based command line analyzer cache size to 512. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Really inscrease to 512 #

Messages