Issue 19552002: Fix for running the tests on the dart-editor-win bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19552002: Fix for running the tests on the dart-editor-win bot. (Closed)

Created:
7 years, 5 months ago by devoncarew

Modified:
7 years, 5 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for running the tests on the dart-editor-win bot. Committed: https://code.google.com/p/dart/source/detail?r=25104

Patch Set 2 : #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -15 lines)			Patch
	M	editor/build/build.py	View	1	1 chunk	+26 lines, -13 lines	2 comments	Download
	M	tools/bots/editor.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/19552002/diff/2001/editor/build/build.py File editor/build/build.py (right): https://codereview.chromium.org/19552002/diff/2001/editor/build/build.py#newcode782 editor/build/build.py:782: if (subprocess.call(args, shell=IsWindows())): No need for outermost '(', ...

7 years, 5 months ago (2013-07-17 13:47:06 UTC) #2

devoncarew

https://codereview.chromium.org/19552002/diff/2001/editor/build/build.py File editor/build/build.py (right): https://codereview.chromium.org/19552002/diff/2001/editor/build/build.py#newcode782 editor/build/build.py:782: if (subprocess.call(args, shell=IsWindows())): On 2013/07/17 13:47:06, kustermann wrote: > ...

7 years, 5 months ago (2013-07-17 16:29:49 UTC) #3

devoncarew

7 years, 5 months ago (2013-07-17 16:30:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25104 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19552002: Fix for running the tests on the dart-editor-win bot. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages