Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 19543009: renamed abstract to abztract due to keyword usage as a variable name. (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
CC:
Emily Fortuna, Tate Mandel
Visibility:
Public.

Description

renamed abstract to abztract due to keyword usage as a variable name. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25172

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 2 5 chunks +43 lines, -19 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
janicejl
This is the same code as the previous CL on categorizing class types. Only change ...
7 years, 5 months ago (2013-07-18 18:47:17 UTC) #1
Emily Fortuna
abztract is just classes, right? I we could call the variable "abstractClasses". otherwise, lgtm.
7 years, 5 months ago (2013-07-18 19:45:40 UTC) #2
janicejl
7 years, 5 months ago (2013-07-18 20:10:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r25172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698