Issue 195333002: Unboxed Float64x2 fields and some misc fixes

Issue 195333002: Unboxed Float64x2 fields and some misc fixes (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
zra, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Unboxed Float64x2 fields and some misc fixes R=srdjan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=33542

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+245 lines, -12 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	9 chunks	+85 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	11 chunks	+72 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	11 chunks	+69 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/195333002/diff/10008/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/195333002/diff/10008/runtime/vm/intermediate_language_arm.cc#newcode1771 runtime/vm/intermediate_language_arm.cc:1771: __ b(&store_float32x4, EQ); 64x2? https://codereview.chromium.org/195333002/diff/10008/runtime/vm/object.cc File runtime/vm/object.cc (right): ...

6 years, 9 months ago (2014-03-11 16:55:33 UTC) #2

Cutch

https://codereview.chromium.org/195333002/diff/10008/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/195333002/diff/10008/runtime/vm/intermediate_language_arm.cc#newcode1771 runtime/vm/intermediate_language_arm.cc:1771: __ b(&store_float32x4, EQ); On 2014/03/11 16:55:33, zra wrote: > ...

6 years, 9 months ago (2014-03-11 17:05:27 UTC) #3

Cutch

6 years, 9 months ago (2014-03-11 17:59:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r33542 (presubmit successful).

Expand Messages | Collapse Messages