Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 19523003: Use a utils.TempDir() decorator for temporary files, to make sure we clean up even in case of excep… (Closed)

Created:
7 years, 5 months ago by kustermann
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use a utils.TempDir() context manager for temporary files, to make sure we clean up even in case of exceptions R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=25091

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M editor/build/build.py View 1 3 chunks +71 lines, -75 lines 0 comments Download
M tools/bots/editor.py View 4 chunks +2 lines, -12 lines 0 comments Download
M tools/utils.py View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 5 months ago (2013-07-17 10:43:57 UTC) #1
kustermann
Context: The editor script leaked a few of these temporary directories today (each in the ...
7 years, 5 months ago (2013-07-17 10:45:05 UTC) #2
kustermann
7 years, 5 months ago (2013-07-17 10:56:05 UTC) #3
Anders Johnsen
lgtm
7 years, 5 months ago (2013-07-17 11:03:32 UTC) #4
kustermann
7 years, 5 months ago (2013-07-17 11:40:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698