Issue 19520019: Reverting 25196, 25195, 25192.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19520019: Reverting 25196, 25195, 25192. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reverting 25196, 25195, 25192. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25197

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -1875 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	8 chunks	+37 lines, -535 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	8 chunks	+37 lines, -535 lines	0 comments	Download
D	tests/html/element_dimensions_test.dart	View	1 chunk	+0 lines, -263 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tools/dom/src/CssRectangle.dart	View	1 chunk	+0 lines, -259 lines	0 comments	Download
D	tools/dom/src/Dimension.dart	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	tools/dom/src/Rectangle.dart	View	2 chunks	+32 lines, -48 lines	1 comment	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	5 chunks	+5 lines, -147 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR :-( Dartium still has some other failures that look minor, but since I'm on ...

7 years, 5 months ago (2013-07-19 02:01:31 UTC) #1

Emily Fortuna

Committed patchset #1 manually as r25197 (presubmit successful).

7 years, 5 months ago (2013-07-19 02:02:13 UTC) #2

Jennifer Messerly

7 years, 5 months ago (2013-07-19 02:22:59 UTC) #3

Message was sent while issue was closed.

Sadness! Looks like the VM is being more picky.

One thing to try is running the analyzer(s) over html_dartium or html_dart2js
and see if they find anything in analysis mode.

revert lgtm tho :|

https://codereview.chromium.org/19520019/diff/1/tools/dom/src/Rectangle.dart
File tools/dom/src/Rectangle.dart (left):

https://codereview.chromium.org/19520019/diff/1/tools/dom/src/Rectangle.dart#...
tools/dom/src/Rectangle.dart:124: class Rect extends RectBase {
The fix might be to use a mixin: "extends Object with RectBase"

or alternatively, put Rect back at the bottom of the hierarchy...

Expand Messages | Collapse Messages