Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1950833002: Fix all strong-mode warnings and errors. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/shelf_io.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/body.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M lib/src/cascade.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/request.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M lib/src/util.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cascade_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M test/log_middleware_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/message_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/shelf_io_test.dart View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 7 months ago (2016-05-04 00:44:57 UTC) #1
kevmoo
Still seeing errors in test w/ expectAsync – but guessing we don't care much about ...
4 years, 7 months ago (2016-05-04 01:34:17 UTC) #2
nweiz
On 2016/05/04 01:34:17, kevmoo wrote: > Still seeing errors in test w/ expectAsync – but guessing ...
4 years, 7 months ago (2016-05-04 18:09:48 UTC) #3
nweiz
Code review changes
4 years, 7 months ago (2016-05-04 18:10:22 UTC) #4
nweiz
4 years, 7 months ago (2016-05-04 18:11:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce9d0409dce0dede7db84796b0124a58e383032e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698