Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 19503006: Use appPubspec() in more places. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -96 lines) Patch
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/different_repo_name_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_path_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_symlink_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_symlink_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_test.dart View 3 chunks +9 lines, -18 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_install_and_update_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/unknown_source_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 5 months ago (2013-07-22 23:42:48 UTC) #1
nweiz
lgtm
7 years, 5 months ago (2013-07-23 19:59:29 UTC) #2
Bob Nystrom
7 years, 5 months ago (2013-07-23 20:12:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698