Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 19501005: Fix a bug that caused a runtime error when attempting to read metadata of a class without metadata. (Closed)

Created:
7 years, 5 months ago by ahe
Modified:
7 years, 5 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a bug that caused a runtime error when attempting to read metadata of a class without metadata. BUG=http://dartbug.com/11960 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M dart/sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + dart/tests/lib/mirrors/no_metadata_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
7 years, 5 months ago (2013-07-23 17:26:39 UTC) #1
ngeoffray
LGTM
7 years, 5 months ago (2013-07-23 17:35:57 UTC) #2
ahe
7 years, 5 months ago (2013-07-24 07:42:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698