Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 19500016: Fix function premable for native entrypoints. (Closed)

Created:
7 years, 5 months ago by Michael Lippautz (Google)
Modified:
7 years, 5 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

This change introduces nothing new. It only fixes the native entrypoints to use the right macros. BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25315

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -108 lines) Patch
M runtime/lib/mirrors.cc View 1 2 3 13 chunks +53 lines, -108 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-20 00:41:24 UTC) #1
rmacnak
https://chromiumcodereview.appspot.com/19500016/diff/3/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19500016/diff/3/runtime/lib/mirrors.cc#newcode1365 runtime/lib/mirrors.cc:1365: GET_NON_NULL_NATIVE_ARGUMENT(Instance, reflectee, arguments->NativeArgAt(1)); This may be null. https://chromiumcodereview.appspot.com/19500016/diff/3/runtime/lib/mirrors.cc#newcode1401 runtime/lib/mirrors.cc:1401: ...
7 years, 5 months ago (2013-07-22 20:30:41 UTC) #2
Michael Lippautz (Google)
https://chromiumcodereview.appspot.com/19500016/diff/3/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/19500016/diff/3/runtime/lib/mirrors.cc#newcode1365 runtime/lib/mirrors.cc:1365: GET_NON_NULL_NATIVE_ARGUMENT(Instance, reflectee, arguments->NativeArgAt(1)); On 2013/07/22 20:30:41, Ryan Macnak wrote: ...
7 years, 5 months ago (2013-07-22 20:43:14 UTC) #3
siva
lgtm
7 years, 5 months ago (2013-07-22 22:40:53 UTC) #4
Michael Lippautz (Google)
7 years, 5 months ago (2013-07-22 22:49:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r25315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698