Typedef information showing properly.

Typedef information showing properly.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25310

[Alan Knight, 2013-07-19 20:28:15]

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:408: * Returns a map of [Parameter] objects
constructed from inputted mirrors.
Inputted isn't a word, and better to just write write "from [mirrorList]."

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:559: String name;
Do all Indexables have a name? Could this be pushed up to the superclass? And
possibly they all have comments and maybe annotations as well?

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:579: typedefMap['name'] = name;
Either write this as a literal map, or use cascades so you're not repeating
typedefMap so often.

[janicejl, 2013-07-19 21:26:57]

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:408: * Returns a map of [Parameter] objects
constructed from inputted mirrors.
On 2013/07/19 20:28:15, Alan Knight wrote:
> Inputted isn't a word, and better to just write write "from [mirrorList]."

Done.

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:559: String name;
On 2013/07/19 20:28:15, Alan Knight wrote:
> Do all Indexables have a name? Could this be pushed up to the superclass? And
> possibly they all have comments and maybe annotations as well?

Done. I have moved name and comment up to indexable. I did not move annotations
as Libraries do not have annotations(afaik) and libraries are also indexable.

https://codereview.chromium.org/19500014/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:579: typedefMap['name'] = name;
On 2013/07/19 20:28:15, Alan Knight wrote:
> Either write this as a literal map, or use cascades so you're not repeating
> typedefMap so often.

Done. Also modified all the other toMap functions to stay consistent. They now
all use the literal map.

[Alan Knight, 2013-07-22 20:26:15]

lgtm

Once you're returning a literal map, the whole method could be in => form, but
it's not necessary.

[janicejl, 2013-07-22 22:04:47]

Committed patchset #3 manually as r25310 (presubmit successful).