Add support for passing in vm options to the testing script.

Add support for passing in vm options to the testing script.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25407

[kustermann, 2013-07-23 13:55:18]

lgtm

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:348: 'Extra flags to send to the vm when
running',
Rename: "Extra options passed to the VM when runnings tests"

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1471: // Add general vm options that is given
to the testing script.
"that is given" -> "that were given"

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1474:
list.addAll(configuration['vm-options'].split(" "));
Make sure we don't add empty options (i.e. consider ./test.py --vm-options="a  b
c").

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1476: }
This change is not going to work. I think this function "getVmOptions()" will be
called multiple times with the same argument. So we could end up adding the
options multiple times.

[kustermann, 2013-07-23 13:55:47]

I hit the wrong button. It was not supposed to be an 'lgtm'.

[ricow1, 2013-07-24 11:32:50]

PTAL, adding the options to that list was just plane stupid

I now extracted this into a function and added them before constructing the
command. We could optimize this by adding it in the initialization of the
infoFromFile, but it does not really belong there (since this is not coming from
file).

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:348: 'Extra flags to send to the vm when
running',
On 2013/07/23 13:55:18, kustermann wrote:
> Rename: "Extra options passed to the VM when runnings tests"

Done.

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1471: // Add general vm options that is given
to the testing script.
On 2013/07/23 13:55:18, kustermann wrote:
> "that is given" -> "that were given"

Done.

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1474:
list.addAll(configuration['vm-options'].split(" "));
On 2013/07/23 13:55:18, kustermann wrote:
> Make sure we don't add empty options (i.e. consider ./test.py --vm-options="a 
b
> c").

Done.

https://codereview.chromium.org/19483008/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1476: }
On 2013/07/23 13:55:18, kustermann wrote:
> This change is not going to work. I think this function "getVmOptions()" will
be
> called multiple times with the same argument. So we could end up adding the
> options multiple times.

Done.

[kustermann, 2013-07-24 12:09:55]

LGTM this time :-)

[ricow1, 2013-07-24 12:23:11]

Committed patchset #3 manually as r25407 (presubmit successful).