Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 19482024: fix parsing of semantic template interation w/ shadowdom polyfill (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M pkg/mdv/test/mdv_test_utils.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/mdv/test/template_element_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
7 years, 5 months ago (2013-07-22 20:51:58 UTC) #1
justinfagnani
lgtm https://chromiumcodereview.appspot.com/19482024/diff/1/pkg/mdv/test/template_element_test.dart File pkg/mdv/test/template_element_test.dart (left): https://chromiumcodereview.appspot.com/19482024/diff/1/pkg/mdv/test/template_element_test.dart#oldcode1121 pkg/mdv/test/template_element_test.dart:1121: if (!TemplateElement.supported) return; Does TemplateElement.supported work properly? Does ...
7 years, 5 months ago (2013-07-23 21:05:14 UTC) #2
Jennifer Messerly
https://chromiumcodereview.appspot.com/19482024/diff/1/pkg/mdv/test/template_element_test.dart File pkg/mdv/test/template_element_test.dart (left): https://chromiumcodereview.appspot.com/19482024/diff/1/pkg/mdv/test/template_element_test.dart#oldcode1121 pkg/mdv/test/template_element_test.dart:1121: if (!TemplateElement.supported) return; On 2013/07/23 21:05:14, justinfagnani wrote: > ...
7 years, 5 months ago (2013-07-23 21:09:32 UTC) #3
Jennifer Messerly
7 years, 5 months ago (2013-07-23 21:17:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698