Issue 194813008: Add compile timestamp to Code

Issue 194813008: Add compile timestamp to Code (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add compile timestamp to Code R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33555

Patch Set 1 #

Total comments: 6

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	runtime/vm/object.h	View	2 chunks	+8 lines, -0 lines	4 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/194813008/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/194813008/diff/1/runtime/vm/object.cc#newcode10248 runtime/vm/object.cc:10248: result.set_comments(Comments::New(0)); Should the timestamp be initialized to 0 ...

6 years, 9 months ago (2014-03-11 20:32:07 UTC) #2

Cutch

https://codereview.chromium.org/194813008/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/194813008/diff/1/runtime/vm/object.cc#newcode10248 runtime/vm/object.cc:10248: result.set_comments(Comments::New(0)); On 2014/03/11 20:32:08, siva wrote: > Should the ...

6 years, 9 months ago (2014-03-11 21:09:15 UTC) #3

Cutch

6 years, 9 months ago (2014-03-11 21:14:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r33555 (presubmit successful).

Expand Messages | Collapse Messages