Issue 1947683006: Bring in the latest version of the SDK's WebSocket impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1947683006: Bring in the latest version of the SDK's WebSocket impl. (Closed)

Created:
4 years, 7 months ago by nweiz

Modified:
4 years, 7 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
git@github.com:dart-lang/web_socket_channel.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Bring in the latest version of the SDK's WebSocket impl. R=alanknight@google.com Committed: https://github.com/dart-lang/web_socket_channel/commit/213b7e711486dfa145c344382c4e82f5562cd8bf

Patch Set 1 #

Patch Set 2 : Merge again #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -209 lines)			Patch
M	lib/src/copy/bytes_builder.dart	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	lib/src/copy/io_sink.dart	View	1	4 chunks	+37 lines, -43 lines	0 comments	Download
M	lib/src/copy/web_socket.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/src/copy/web_socket_impl.dart	View	1	26 chunks	+190 lines, -160 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

On 2016/05/05 16:32:42, Alan Knight wrote: > lgtm PTAL; I updated this to include https://github.com/dart-lang/sdk/commit/e41fb4cafd6052157dbc1490d437045240f4773f ...

4 years, 7 months ago (2016-05-05 17:34:45 UTC) #3

nweiz

4 years, 7 months ago (2016-05-05 19:36:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
213b7e711486dfa145c344382c4e82f5562cd8bf (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages