Address some drive-by comments: equality without hash, types in the instantiation expression.

Address some drive-by comments: equality without hash, types in the instantiation expression.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25478

[ahe, 2013-07-24 17:04:13]

lgtm

[rmacnak, 2013-07-24 17:25:42]

On 2013/07/24 17:04:13, ahe wrote:
> lgtm

Hm, running a more thorough presubmit check in checked mode, I find I cannot say
"const Map<Symbol, Mirror>()" because Map has no const constructor. Is it
possible to add type annotations to a map literal? If no, it is more important
to have a const map or an annotated map?

[rmacnak, 2013-07-24 17:34:06]

On 2013/07/24 17:25:42, Ryan Macnak wrote:
> On 2013/07/24 17:04:13, ahe wrote:
> > lgtm
> 
> Hm, running a more thorough presubmit check in checked mode, I find I cannot
say
> "const Map<Symbol, Mirror>()" because Map has no const constructor. Is it
> possible to add type annotations to a map literal? If no, it is more important
> to have a const map or an annotated map?

Okay, it's "const <Symbol, Mirror>{}", but checked mode remains unhappy because
it insists the key type of a map literal must be String. Revert to an typed map?

[ahe, 2013-07-25 09:07:54]

On 2013/07/24 17:34:06, Ryan Macnak wrote:
> On 2013/07/24 17:25:42, Ryan Macnak wrote:
> > On 2013/07/24 17:04:13, ahe wrote:
> > > lgtm
> > 
> > Hm, running a more thorough presubmit check in checked mode, I find I cannot
> say
> > "const Map<Symbol, Mirror>()" because Map has no const constructor. Is it
> > possible to add type annotations to a map literal? If no, it is more
important
> > to have a const map or an annotated map?
> 
> Okay, it's "const <Symbol, Mirror>{}", but checked mode remains unhappy
because
> it insists the key type of a map literal must be String. Revert to an typed
map?

Just make it non-const.

[rmacnak, 2013-07-25 16:37:08]

Committed patchset #3 manually as r25478 (presubmit successful).