Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 19469003: Do not use the NamedMixinApplication node for anonymous mixins: otherwise, the [MixinApplicationEle… (Closed)

Created:
7 years, 5 months ago by ngeoffray
Modified:
7 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not use the NamedMixinApplication node for anonymous mixins: otherwise, the [MixinApplicationElement.computeTypeParameters] would create additional type variables that should not exist. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25202

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/mixin_type_parameter1_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download
A tests/language/mixin_type_parameter2_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A tests/language/mixin_type_parameter3_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 5 months ago (2013-07-19 10:41:44 UTC) #1
karlklose
LGTM.
7 years, 5 months ago (2013-07-19 10:53:41 UTC) #2
ngeoffray
7 years, 5 months ago (2013-07-19 10:59:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698