Issue 194663005: Take is checks into account when deriving interceptor classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194663005: Take is checks into account when deriving interceptor classes. (Closed)

Created:
6 years, 9 months ago by herhut

Modified:
6 years, 9 months ago

Reviewers:
floitsch, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Added test to ensure that is checks are taken into account when deriving interceptor classes. BUG= http://dartbug.com/17325 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33571

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	A	tests/language/interceptor9_test.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

Add tests. LGTM if it doesn't have a noticeable size change for our common benchmarks. ...

6 years, 9 months ago (2014-03-11 17:07:06 UTC) #2

sra1

I think https://code.google.com/p/dart/source/detail?r=33517 fixes this issue.

6 years, 9 months ago (2014-03-11 17:18:12 UTC) #3

herhut

On 2014/03/11 17:18:12, sra1 wrote: > I think https://code.google.com/p/dart/source/detail?r=33517 fixes this issue. Indeed. I have ...

6 years, 9 months ago (2014-03-12 10:41:46 UTC) #4

herhut

6 years, 9 months ago (2014-03-12 11:39:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33571 (presubmit successful).