Interpose an Expando cache on reflectClass().

Interpose an Expando cache on reflectClass().

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25181

[rmacnak, 2013-07-18 19:49:22]

Improves the DI-w/-testing benchmark from 121 to 10 ms.

[Ivan Posva, 2013-07-18 20:41:46]

LGTMwC

-Ivan

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:1123: static Expando<ClassMirror> classMirrorCache
= new Expando();
If you don't mind, can you please give this Expando a name? Will make it easier
to identify.

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:1126: if (classMirror != null) {
How about avoiding duplicate returns:

if (classMirror == null) {
  classMirror = makeLocalClassMirror(key);
  classMirrorCache[key] = classMirror;
}
return classMirror;

[rmacnak, 2013-07-18 20:49:29]

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:1123: static Expando<ClassMirror> classMirrorCache
= new Expando();
On 2013/07/18 20:41:46, Ivan Posva wrote:
> If you don't mind, can you please give this Expando a name? Will make it
easier
> to identify.

Done.

https://codereview.chromium.org/19462008/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:1126: if (classMirror != null) {
On 2013/07/18 20:41:46, Ivan Posva wrote:
> How about avoiding duplicate returns:
> 
> if (classMirror == null) {
>   classMirror = makeLocalClassMirror(key);
>   classMirrorCache[key] = classMirror;
> }
> return classMirror;

Done.

[rmacnak, 2013-07-18 20:54:48]

Committed patchset #2 manually as r25181 (presubmit successful).

[siva, 2013-07-18 20:55:10]

lgtm