Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 19462004: Disable allocation sinking in the presence of try-catch. (Closed)

Created:
7 years, 5 months ago by Florian Schneider
Modified:
7 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Disable allocation sinking in the presence of try-catch. Allocation sinking does not handle the case of optimized try-catch yet. I added a TODO to support it at a later point. BUG=https://code.google.com/p/dart/issues/detail?id=11873 TEST=tests/language/try_catch_optimized2_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25146

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M runtime/vm/compiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
A tests/language/try_catch_optimized2_test.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years, 5 months ago (2013-07-18 13:52:47 UTC) #1
srdjan
LGTM and thanks for the quick fix https://codereview.chromium.org/19462004/diff/1/tests/language/try_catch_optimized2_test.dart File tests/language/try_catch_optimized2_test.dart (right): https://codereview.chromium.org/19462004/diff/1/tests/language/try_catch_optimized2_test.dart#newcode29 tests/language/try_catch_optimized2_test.dart:29: for (var ...
7 years, 5 months ago (2013-07-18 14:07:00 UTC) #2
Florian Schneider
https://codereview.chromium.org/19462004/diff/1/tests/language/try_catch_optimized2_test.dart File tests/language/try_catch_optimized2_test.dart (right): https://codereview.chromium.org/19462004/diff/1/tests/language/try_catch_optimized2_test.dart#newcode29 tests/language/try_catch_optimized2_test.dart:29: for (var i=0; i<20; i++) foo(a); On 2013/07/18 14:07:00, ...
7 years, 5 months ago (2013-07-18 14:12:46 UTC) #3
Florian Schneider
7 years, 5 months ago (2013-07-18 14:13:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698