Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 194503006: Code view tweaks and crasher fix (Closed)

Created:
6 years, 9 months ago by Cutch
Modified:
6 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Code view tweaks and crasher fix BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=33548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M runtime/bin/vmservice/client/lib/src/elements/code_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/disassembly_entry.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 9 months ago (2014-03-11 19:26:14 UTC) #1
turnidge
lgtm
6 years, 9 months ago (2014-03-11 19:27:19 UTC) #2
Cutch
6 years, 9 months ago (2014-03-11 19:27:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698