Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1940453003: pkg/stack_trace: use List.unmodifiable when possible (Closed)

Created:
4 years, 7 months ago by kevmoo
Modified:
4 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M lib/src/chain.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/src/trace.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kevmoo
4 years, 7 months ago (2016-04-30 01:42:13 UTC) #2
nweiz
lgtm
4 years, 7 months ago (2016-05-03 01:18:32 UTC) #3
kevmoo
4 years, 7 months ago (2016-05-03 03:33:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f8a17f95c3570b65cb015bcbe89775495cfbdce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698