Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 19402003: Rename several classes in barback. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename several classes in barback. AssetProvider -> PackageProvider AssetGraphManager -> PackageGraph AssetGraph -> AssetCascade R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25080

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1284 lines) Patch
M pkg/barback/lib/barback.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset_cascade.dart View 1 5 chunks +20 lines, -15 lines 0 comments Download
D pkg/barback/lib/src/asset_graph.dart View 1 chunk +0 lines, -291 lines 0 comments Download
D pkg/barback/lib/src/asset_graph_manager.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/barback/lib/src/asset_node.dart View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/barback/lib/src/asset_provider.dart View 1 chunk +0 lines, -41 lines 0 comments Download
A + pkg/barback/lib/src/package_graph.dart View 4 chunks +42 lines, -44 lines 0 comments Download
A + pkg/barback/lib/src/package_provider.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/barback/lib/src/phase.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/barback/test/asset_graph/errors_test.dart View 1 1 chunk +0 lines, -176 lines 0 comments Download
M pkg/barback/test/asset_graph/source_test.dart View 1 1 chunk +0 lines, -142 lines 0 comments Download
M pkg/barback/test/asset_graph/transform_test.dart View 1 1 chunk +0 lines, -411 lines 0 comments Download
A + pkg/barback/test/package_graph/errors_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
A + pkg/barback/test/package_graph/source_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
A + pkg/barback/test/package_graph/transform_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/barback/test/utils.dart View 12 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 5 months ago (2013-07-16 23:02:47 UTC) #1
Bob Nystrom
Can you rename the "asset_graph" directory in test too? Otherwise LGTM++++. The more I see ...
7 years, 5 months ago (2013-07-16 23:13:03 UTC) #2
nweiz
Renamed directory. https://codereview.chromium.org/19402003/diff/1/pkg/barback/lib/src/asset_cascade.dart File pkg/barback/lib/src/asset_cascade.dart (right): https://codereview.chromium.org/19402003/diff/1/pkg/barback/lib/src/asset_cascade.dart#newcode28 pkg/barback/lib/src/asset_cascade.dart:28: /// inputs of the first phase are ...
7 years, 5 months ago (2013-07-17 00:33:55 UTC) #3
nweiz
7 years, 5 months ago (2013-07-17 00:34:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698