Issue 19393002: Change how the editor tests run on the buildbots to use the --test option.

Issue 19393002: Change how the editor tests run on the buildbots to use the --test option. (Closed)

Created:
7 years, 5 months ago by devoncarew

Modified:
7 years, 5 months ago

Reviewers:
pquitslund, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change how the editor tests run on the buildbots to use the --test option. R=pquitslund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25061

Patch Set 2 : #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -76 lines)			Patch
M	editor/build/build.py	View		8 chunks	+44 lines, -60 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.core_test/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegateTest.java	View		5 chunks	+13 lines, -4 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/src/com/google/dart/tools/tests/buildbot/BuildbotTestsJob.java	View	1	4 chunks	+21 lines, -11 lines	0 comments	Download
M	tools/bots/editor.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pquitslund

LGTM. Fingers-crossed it even works! :) https://codereview.chromium.org/19393002/diff/2001/editor/tools/plugins/com.google.dart.tools.debug.core_test/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegateTest.java File editor/tools/plugins/com.google.dart.tools.debug.core_test/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegateTest.java (right): https://codereview.chromium.org/19393002/diff/2001/editor/tools/plugins/com.google.dart.tools.debug.core_test/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegateTest.java#newcode40 editor/tools/plugins/com.google.dart.tools.debug.core_test/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegateTest.java:40: // TODO(devoncarew): determine ...

7 years, 5 months ago (2013-07-16 17:06:56 UTC) #2

devoncarew

7 years, 5 months ago (2013-07-16 17:45:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25061 (presubmit successful).

Expand Messages | Collapse Messages