Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 19387005: Workaround for 11854 (broken type check) (Closed)

Created:
7 years, 5 months ago by vsm
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Workaround for 11854 (broken type check) This works around the broken type check. Alexandre: It also works if we use "JsFunction" instead of "Serializable<JsFunction>" for the type check. Is there a case where we have the latter but not the former? I also put in a status fix / fail for IE10. That seems to be a separate issue. BUG=11849 R=alexandre.ardhuin@gmail.com Committed: https://code.google.com/p/dart/source/detail?r=25065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/html/html.status View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
7 years, 5 months ago (2013-07-16 19:34:41 UTC) #1
alexandre.ardhuin
> Is there a case where we have the latter but not the former? Callback ...
7 years, 5 months ago (2013-07-16 19:49:18 UTC) #2
alexandre.ardhuin
On 2013/07/16 19:49:18, alexandre.ardhuin wrote: > > Is there a case where we have the ...
7 years, 5 months ago (2013-07-16 19:51:32 UTC) #3
alexandre.ardhuin
lgtm
7 years, 5 months ago (2013-07-16 19:52:12 UTC) #4
vsm
On 2013/07/16 19:51:32, alexandre.ardhuin wrote: > On 2013/07/16 19:49:18, alexandre.ardhuin wrote: > > > Is ...
7 years, 5 months ago (2013-07-16 19:53:12 UTC) #5
vsm
7 years, 5 months ago (2013-07-16 19:55:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r25065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698