Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 193723006: Add script to create a Debian chroot environment (Closed)

Created:
6 years, 9 months ago by Søren Gjesse
Modified:
6 years, 9 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add script to create a Debian chroot environment For building Debian wheezy compatable binary packages we need to set up a number of Debian chroot environments. To avoid to many manual steps this script should do the bulk of this work. To create a chroot environment for building 64-bit stable: $ tools/create_debian_chroot.sh amd64 stable /tmp/debian_amd64_stable Then building the Debian image should be as easy as $ sudo chroot /tmp/debian_amd_stable $ cd /b/dart $ tools/create_tarball.py $ tools/build_debian_packages.py amd64 The build_debian_packages.py is still missing the architecture argument. R=ricow@google.com, whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34162

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed review comments #

Total comments: 5

Patch Set 3 : Addresses second round of comments #

Patch Set 4 : Long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
A tools/create_debian_chroot.sh View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Søren Gjesse
6 years, 9 months ago (2014-03-11 08:02:29 UTC) #1
ricow1
dbc So what is this for, with the user creation I would assume the bots, ...
6 years, 9 months ago (2014-03-11 09:14:31 UTC) #2
Bill Hesse
I think that we need multiple, different chroots, with different architectures. If the buildbot runs ...
6 years, 9 months ago (2014-03-11 09:36:01 UTC) #3
Søren Gjesse
PTAL I updated the script to take three arguments 1. Architecture 2. Destination dir (optional) ...
6 years, 9 months ago (2014-03-19 07:46:57 UTC) #4
ricow1
LGTM https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh File tools/create_debian_chroot.sh (right): https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh#newcode27 tools/create_debian_chroot.sh:27: #if [ $# -gt 1 ] commented out ...
6 years, 9 months ago (2014-03-19 08:08:32 UTC) #5
Bill Hesse
lgtm https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh File tools/create_debian_chroot.sh (right): https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh#newcode18 tools/create_debian_chroot.sh:18: # Expect two arguments, architecture, channel and optional ...
6 years, 9 months ago (2014-03-20 10:20:20 UTC) #6
Søren Gjesse
Improved the usage message as well. https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh File tools/create_debian_chroot.sh (right): https://codereview.chromium.org/193723006/diff/20001/tools/create_debian_chroot.sh#newcode18 tools/create_debian_chroot.sh:18: # Expect two ...
6 years, 9 months ago (2014-03-20 10:54:16 UTC) #7
Søren Gjesse
6 years, 9 months ago (2014-03-20 10:55:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r34162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698