Issue 193643003: pkg/unittest: support up to 6 arguments in expectAsync[Until]

Issue 193643003: pkg/unittest: support up to 6 arguments in expectAsync[Until] (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
nweiz, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: support up to 6 arguments in expectAsync[Until] Also support for default values in provided functions removed deprecated in most tests whitespace cleanup R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=33560

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 1

Patch Set 3 : rebase #

Total comments: 3

Patch Set 4 : doc comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -127 lines)			Patch
M	pkg/pkg.status	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/spread_args_helper.dart	View	1 2 3	4 chunks	+53 lines, -20 lines	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View		3 chunks	+4 lines, -47 lines	0 comments	Download
M	pkg/unittest/test/missing_tick_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/test_utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/unittest_async_exception_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/test/unittest_async_setup_teardown_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/unittest/test/unittest_completion_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/unittest_correct_callback_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/unittest_excess_callback_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A	pkg/unittest/test/unittest_expect_async_args_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A	pkg/unittest/test/unittest_expect_async_test.dart	View		1 chunk	+95 lines, -0 lines	0 comments	Download
M	pkg/unittest/test/unittest_late_exception_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/test/unittest_middle_exception_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/unittest_protect_async_test.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	pkg/unittest/test/unittest_test_returning_future_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/unittest/test/unittest_test_returning_future_using_runasync_test.dart	View		1 chunk	+18 lines, -28 lines	0 comments	Download
M	pkg/unittest/test/unittest_test_utils.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

I addressed everything from last weeks blow-up plus... https://codereview.chromium.org/193643003/diff/20001/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/193643003/diff/20001/pkg/pkg.status#newcode288 pkg/pkg.status:288: polymer/example/canonicalization/test/deploy_test: ...

6 years, 9 months ago (2014-03-11 03:22:41 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/193643003/diff/40001/pkg/unittest/test/unittest_expect_async_test.dart File pkg/unittest/test/unittest_expect_async_test.dart (right): https://codereview.chromium.org/193643003/diff/40001/pkg/unittest/test/unittest_expect_async_test.dart#newcode90 pkg/unittest/test/unittest_expect_async_test.dart:90: final expected = '8:0:0:8:8:::null:expectAsync zero params:' doesn't have ...

6 years, 9 months ago (2014-03-11 03:37:41 UTC) #2

kevmoo

A bit of cleanup first...please hold https://codereview.chromium.org/193643003/diff/40001/pkg/unittest/lib/src/spread_args_helper.dart File pkg/unittest/lib/src/spread_args_helper.dart (right): https://codereview.chromium.org/193643003/diff/40001/pkg/unittest/lib/src/spread_args_helper.dart#newcode99 pkg/unittest/lib/src/spread_args_helper.dart:99: //TODO(kevmoo) DOCUMENT! I'm ...

6 years, 9 months ago (2014-03-11 03:46:46 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-11 22:22:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r33560 (presubmit successful).

Expand Messages | Collapse Messages