Issue 19347002: Fix crash https://code.google.com/p/dart/issues/detail?id=11793: only compute a range for a loop if…

Issue 19347002: Fix crash https://code.google.com/p/dart/issues/detail?id=11793: only compute a range for a loop if… (Closed)

Created:
7 years, 5 months ago by ngeoffray

Modified:
7 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash https://code.google.com/p/dart/issues/detail?id=11793: only compute a range for a loop if all its inputs are integer. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25043

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/language/issue11793_test.dart	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/19347002/diff/4001/tests/language/issue11793_test.dart File tests/language/issue11793_test.dart (right): https://codereview.chromium.org/19347002/diff/4001/tests/language/issue11793_test.dart#newcode9 tests/language/issue11793_test.dart:9: var _b = array[0]; b_ -> b2? https://codereview.chromium.org/19347002/diff/4001/tests/language/issue11793_test.dart#newcode27 ...

7 years, 5 months ago (2013-07-16 09:26:17 UTC) #2

ngeoffray

Thanks Karl. https://codereview.chromium.org/19347002/diff/4001/tests/language/issue11793_test.dart File tests/language/issue11793_test.dart (right): https://codereview.chromium.org/19347002/diff/4001/tests/language/issue11793_test.dart#newcode9 tests/language/issue11793_test.dart:9: var _b = array[0]; On 2013/07/16 09:26:17, ...

7 years, 5 months ago (2013-07-16 10:27:06 UTC) #3

ngeoffray

7 years, 5 months ago (2013-07-16 10:27:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25043 (presubmit successful).

Expand Messages | Collapse Messages