Inline Float64x2 methods that take 1 argument

Inline Float64x2 methods that take 1 argument

BUG=
R=srdjan@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33506

[zra, 2014-03-10 22:14:08]

lgtm

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4132: __ vmovd(left0, right0, GT);
I double checked the performance guide, and it looks like it recommends
preferring branches instead of conditional FPU instructions. If it's not too
much trouble, why don't we go with that first? Something like:

Label le0;
__ vcmpd(left0, right0);
__ vmstat();
__ b(&le0, LE);
__ vmovd(left0, right0);
__ Bind(&le0)

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4140: __ vmovd(left0, right0, LT);
Same here.

[srdjan, 2014-03-10 22:23:20]

lgtm

[Cutch, 2014-03-10 22:26:44]

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4132: __ vmovd(left0, right0, GT);
On 2014/03/10 22:14:08, zra wrote:
> I double checked the performance guide, and it looks like it recommends
> preferring branches instead of conditional FPU instructions. If it's not too
> much trouble, why don't we go with that first? Something like:
> 
> Label le0;
> __ vcmpd(left0, right0);
> __ vmstat();
> __ b(&le0, LE);
> __ vmovd(left0, right0);
> __ Bind(&le0)

Done.

https://codereview.chromium.org/193183003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4140: __ vmovd(left0, right0, LT);
On 2014/03/10 22:14:08, zra wrote:
> Same here.

Done.

[Cutch, 2014-03-10 22:35:03]

Committed patchset #3 manually as r33506 (presubmit successful).