Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 19309004: reverted back to path instead of pathos and use explicit package root, just like buildbot (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
Visibility:
Public.

Description

reverted back to path instead of pathos and use explicit package root, just like buildbot R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25062

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -63 lines) Patch
M pkg/docgen/lib/dart2yaml.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 3 12 chunks +68 lines, -59 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
janicejl
Only change is going from pathos to path in the import statements. All the other ...
7 years, 5 months ago (2013-07-16 01:21:39 UTC) #1
Bob Nystrom
LGTM.
7 years, 5 months ago (2013-07-16 15:57:46 UTC) #2
janicejl
Made one small change to replace the \n in between a close tag and an ...
7 years, 5 months ago (2013-07-16 16:50:02 UTC) #3
Bob Nystrom
On 2013/07/16 16:50:02, janicejl wrote: > Made one small change to replace the \n in ...
7 years, 5 months ago (2013-07-16 17:13:33 UTC) #4
janicejl
Sorry. Back to assuming the Viewer will handle all the \n characters.
7 years, 5 months ago (2013-07-16 17:48:38 UTC) #5
Bob Nystrom
LGTM!
7 years, 5 months ago (2013-07-16 17:52:08 UTC) #6
janicejl
7 years, 5 months ago (2013-07-16 18:08:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r25062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698