Issue 19289002: Fix the build on 64-bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19289002: Fix the build on 64-bit. (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix the build on 64-bit. Committed: https://code.google.com/p/dart/source/detail?r=25025

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	runtime/lib/mirrors.cc	View		1 chunk	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #1 manually as r25025 (presubmit successful).

7 years, 5 months ago (2013-07-15 21:28:02 UTC) #1

regis

7 years, 5 months ago (2013-07-15 22:34:26 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/19289002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/19289002/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:1479: String::NewFormatted("%s: did not find static
method '%s.%s'.",
FYI, instead of "find  %d-arg", you would write "find %"Pd"-arg".

Expand Messages | Collapse Messages