Return a different exit code from the vm after compilation errors (issue 5525).

Return a different exit code from the vm after compilation errors (issue 5525).

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25034

[siva, 2013-07-15 22:42:20]

lgtm

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc#newcode597
runtime/bin/main.cc:597: static const int kErrorExitCode = 255;  // Indicates we
encountered an error.
Should we change the comment of this to state
// Indicates a generic unhandled error.
or something like that.

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc#newcode616
runtime/bin/main.cc:616: kCompilationErrorExitCode: kErrorExitCode;
kCompilationErrorExitCode : kErrorExitCode

[regis, 2013-07-15 23:32:47]

Thanks!

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc#newcode597
runtime/bin/main.cc:597: static const int kErrorExitCode = 255;  // Indicates we
encountered an error.
On 2013/07/15 22:42:20, siva wrote:
> Should we change the comment of this to state
> // Indicates a generic unhandled error.
> or something like that.

Done.

https://codereview.chromium.org/19284006/diff/1/runtime/bin/main.cc#newcode616
runtime/bin/main.cc:616: kCompilationErrorExitCode: kErrorExitCode;
On 2013/07/15 22:42:20, siva wrote:
> kCompilationErrorExitCode : kErrorExitCode

Done.

[regis, 2013-07-15 23:33:27]

Committed patchset #2 manually as r25034 (presubmit successful).