Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 19282004: Attempting to fix XHR test. (Closed)

Created:
7 years, 5 months ago by blois
Modified:
7 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Attempting to fix XHR test. The test randomly started failing recently, appears to be caused by a Chrome bug related to timing of requests and the startup sequence of Chrome. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=25031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tests/html/xhr_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 5 months ago (2013-07-15 22:22:32 UTC) #1
Emily Fortuna
lgtm :-/
7 years, 5 months ago (2013-07-15 22:27:05 UTC) #2
blois
7 years, 5 months ago (2013-07-15 22:51:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698