Filter out accessors for fields.

Filter out accessors for fields.

BUG=http://dartbug.com/6490
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25084

[ngeoffray, 2013-07-17 07:20:03]

LGTM

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:480: // TODO(ahe): This is a hack to
remove getters corresponding to a field.
Why do you add this local? The TODO line 487 could just as well use [variables],
right?

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:498: // TODO(ahe): This is a hack to
remove setters corresponding to a field.
ditto.

[ahe, 2013-07-17 07:38:32]

Thank you, Nicolas.

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:480: // TODO(ahe): This is a hack to
remove getters corresponding to a field.
On 2013/07/17 07:20:03, ngeoffray wrote:
> Why do you add this local? The TODO line 487 could just as well use
[variables],
> right?

That would be slow as variables create a new map each time called.

[ngeoffray, 2013-07-17 07:42:41]

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:480: // TODO(ahe): This is a hack to
remove getters corresponding to a field.
On 2013/07/17 07:38:32, ahe wrote:
> On 2013/07/17 07:20:03, ngeoffray wrote:
> > Why do you add this local? The TODO line 487 could just as well use
> [variables],
> > right?
> 
> That would be slow as variables create a new map each time called.

Expensive getters for the win :) Is that the mirrors API? Why don't you cache
things?

[ahe, 2013-07-17 08:00:36]

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/19275012/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:480: // TODO(ahe): This is a hack to
remove getters corresponding to a field.
On 2013/07/17 07:42:42, ngeoffray wrote:
> On 2013/07/17 07:38:32, ahe wrote:
> > On 2013/07/17 07:20:03, ngeoffray wrote:
> > > Why do you add this local? The TODO line 487 could just as well use
> > [variables],
> > > right?
> > 
> > That would be slow as variables create a new map each time called.
> 
> Expensive getters for the win :) Is that the mirrors API? Why don't you cache
> things?

Actually, the specification says "immutable map". So I should be able to make
the accessors faster.  I have filed http://dartbug.com/11866.

[ahe, 2013-07-17 08:20:44]

Committed patchset #1 manually as r25084 (presubmit successful).