Issue 19267007: Fix test that fails in checked mode: a factory must return a subtype of its defining class.

Issue 19267007: Fix test that fails in checked mode: a factory must return a subtype of its defining class. (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix test that fails in checked mode: a factory must return a subtype of its defining class. Committed: https://code.google.com/p/dart/source/detail?r=25026

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	tests/lib/mirrors/mirrors_test.dart	View		2 chunks	+6 lines, -3 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rmacnak

On 2013/07/15 22:10:40, Ryan Macnak wrote: TBR=regis@google.com

7 years, 5 months ago (2013-07-15 22:12:45 UTC) #2

rmacnak

Committed patchset #1 manually as r25026 (presubmit successful).

7 years, 5 months ago (2013-07-15 22:13:05 UTC) #3

regis

LGTM https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_test.dart File tests/lib/mirrors/mirrors_test.dart (right): https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_test.dart#newcode13 tests/lib/mirrors/mirrors_test.dart:13: class Class<T> { Is there any particular reason ...

7 years, 5 months ago (2013-07-15 22:37:35 UTC) #4

rmacnak

https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_test.dart File tests/lib/mirrors/mirrors_test.dart (right): https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_test.dart#newcode13 tests/lib/mirrors/mirrors_test.dart:13: class Class<T> { On 2013/07/15 22:37:35, regis wrote: > ...

7 years, 5 months ago (2013-07-16 00:03:21 UTC) #5

regis

7 years, 5 months ago (2013-07-16 00:07:16 UTC) #6

Message was sent while issue was closed.

On 2013/07/16 00:03:21, Ryan Macnak wrote:
>
https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_tes...
> File tests/lib/mirrors/mirrors_test.dart (right):
> 
>
https://codereview.chromium.org/19267007/diff/1/tests/lib/mirrors/mirrors_tes...
> tests/lib/mirrors/mirrors_test.dart:13: class Class<T> {
> On 2013/07/15 22:37:35, regis wrote:
> > Is there any particular reason why Class has a type parameter that is never
> > used?
> 
> Another test in this file inspects it reflectively.

I missed that.
Thanks

Expand Messages | Collapse Messages