Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 19266005: Use pathos.fromUri() to make it work on Windows. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use pathos.fromUri() to make it work on Windows. I was able to reproduce failure on Windows bots. With this CL should work on both Windows and Posix. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 6 chunks +19 lines, -17 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_io.dart View 6 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 5 months ago (2013-07-15 23:58:50 UTC) #1
Brian Wilkerson
LGTM
7 years, 5 months ago (2013-07-16 13:46:31 UTC) #2
scheglov
7 years, 5 months ago (2013-07-16 16:35:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698