Fix for JavaFile.getCanonicalPath(), don't use Path.

Fix for JavaFile.getCanonicalPath(), don't use Path.

I've tested JavaFile manually separately; and ran shared tests.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=25016

[Brian Wilkerson, 2013-07-15 18:38:42]

https://codereview.chromium.org/19262002/diff/1/editor/util/plugins/com.googl...
File editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart
(right):

https://codereview.chromium.org/19262002/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart:91: String
getCanonicalPath() => _newFile().fullPathSync();
While the comment for this method reads "Synchronously get the canonical full
path corresponding to the file path.", the comment in Path that talks about
getting a canonical path indicates that it only removes '.' and '..' segments.
It doesn't say anything about symlinks. I haven't written a test, but I'm
guessing that this method doesn't resolve symlinks either. Did you test it? (I
think we need to write this ourselves, and I think I know how.)

[scheglov, 2013-07-15 19:21:58]

On 2013/07/15 18:38:42, Brian Wilkerson wrote:
>
https://codereview.chromium.org/19262002/diff/1/editor/util/plugins/com.googl...
> File editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart
> (right):
> 
>
https://codereview.chromium.org/19262002/diff/1/editor/util/plugins/com.googl...
> editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart:91:
String
> getCanonicalPath() => _newFile().fullPathSync();
> While the comment for this method reads "Synchronously get the canonical full
> path corresponding to the file path.", the comment in Path that talks about
> getting a canonical path indicates that it only removes '.' and '..' segments.
> It doesn't say anything about symlinks. I haven't written a test, but I'm
> guessing that this method doesn't resolve symlinks either. Did you test it? (I
> think we need to write this ourselves, and I think I know how.)

Yes, I've tests this.

May be comment for File should be improved.
but in theory comment for File as class tells that all methods operate with the
target of the link:

/**
 * [File] objects are references to files.
 *
 * If [path] is a symbolic link, rather than a file, then
 * the methods of [File] operate on the ultimate target of the
 * link, except for File.delete and File.deleteSync, which operate on
 * the link.
 *
 * [cut]
 */
abstract class File implements FileSystemEntity {








main() {
  JavaFile f = new
JavaFile("/Users/scheglov/Source/Dart/dart/pkg/analyzer_experimental/test/packages/analyzer_experimental/options.dart");
  print(f);
  print(f.getCanonicalPath());
}

/Users/scheglov/Source/Dart/dart/pkg/analyzer_experimental/test/packages/analyzer_experimental/options.dart
/Users/scheglov/Source/Dart/dart/pkg/analyzer_experimental/lib/options.dart

[Brian Wilkerson, 2013-07-15 19:34:21]

LGTM

[scheglov, 2013-07-15 19:35:21]

Committed patchset #1 manually as r25016 (presubmit successful).