Inline Float64x2 methods with zero arguments

Inline Float64x2 methods with zero arguments

BUG=
R=srdjan@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33504

[zra, 2014-03-10 20:43:38]

arm/mips lgtm with small fix

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4034: summary->set_in(0,
Location::RequiresFpuRegister());
Location::RequiresFpuRegister(Q6) if op_kind() == GetSignMask

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4057: __ vmovrs(out,
OddSRegisterOf(dvalue0));
Grabbing the S components means we need a low-numbered Q register, e.g. Q6.

[srdjan, 2014-03-10 20:45:57]

lgtm

https://codereview.chromium.org/192573008/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:7985: void
ConstantPropagator::VisitFloat64x2ZeroArg(Float64x2ZeroArgInstr* instr) {
Add a TODO to implement constant propagation for Float64x2ZeroArg.

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:775: 
Why the extra new line?

[Cutch, 2014-03-10 20:52:46]

https://codereview.chromium.org/192573008/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:7985: void
ConstantPropagator::VisitFloat64x2ZeroArg(Float64x2ZeroArgInstr* instr) {
On 2014/03/10 20:45:58, srdjan wrote:
> Add a TODO to implement constant propagation for Float64x2ZeroArg.

Done.

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:775: 
On 2014/03/10 20:45:58, srdjan wrote:
> Why the extra new line?

Done.

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4034: summary->set_in(0,
Location::RequiresFpuRegister());
On 2014/03/10 20:43:38, zra wrote:
> Location::RequiresFpuRegister(Q6) if op_kind() == GetSignMask

Done.

https://codereview.chromium.org/192573008/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:4057: __ vmovrs(out,
OddSRegisterOf(dvalue0));
On 2014/03/10 20:43:38, zra wrote:
> Grabbing the S components means we need a low-numbered Q register, e.g. Q6.

Done.

[Cutch, 2014-03-10 20:58:13]

Committed patchset #2 manually as r33504 (presubmit successful).