Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 19256021: Merges ARM load/store type enums into one enum. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Merges ARM load/store type enums into one enum. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -144 lines) Patch
M runtime/vm/assembler_arm.h View 5 chunks +18 lines, -27 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 17 chunks +72 lines, -47 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 11 chunks +11 lines, -22 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 15 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 5 months ago (2013-07-16 18:12:13 UTC) #1
regis
LGTM!
7 years, 5 months ago (2013-07-16 18:25:41 UTC) #2
zra
7 years, 5 months ago (2013-07-16 18:32:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698