Issue 192363003: Translate Java's @Override into Dart's @override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192363003: Translate Java's @Override into Dart's @override. (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Translate Java's @Override into Dart's @override. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33474

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3600 lines, -15 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/index/Location.java	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/index/LocationWithData.java	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/index/MemoryIndexStoreImpl.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/index/MemoryIndexStoreImplTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineAnnotationProcessor.java	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/ToFormattedSourceVisitor.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/EngineAnnotationProcessorTest.java	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	422 chunks	+1368 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/constant.dart	View	124 chunks	+329 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	230 chunks	+586 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	217 chunks	+303 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	14 chunks	+32 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/html.dart	View	27 chunks	+42 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/index.dart	View	52 chunks	+86 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/instrumentation.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	134 chunks	+213 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	284 chunks	+420 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/scanner.dart	View	15 chunks	+32 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/sdk.dart	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/sdk_io.dart	View	5 chunks	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	8 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	12 chunks	+24 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/element_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	44 chunks	+60 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Do we need to bump the version number? Either way, LGTM.

6 years, 9 months ago (2014-03-10 02:15:29 UTC) #2

scheglov

6 years, 9 months ago (2014-03-10 02:20:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33474 (presubmit successful).

Expand Messages | Collapse Messages