Implement metadata as an internal native. Be honest about which mirrors don't yet support metadata …

Implement metadata as an internal native. Be honest about which mirrors don't yet support metadata introspection.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25126

[rmacnak, 2013-07-16 21:11:14]

https://codereview.chromium.org/19235015/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (left):

https://codereview.chromium.org/19235015/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:73: List<InstanceMirror> _metadata(mirror)
This annotation is incorrect. The native answered an array of plain instances,
which were later wrapped as instance mirrors.

https://codereview.chromium.org/19235015/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/19235015/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:705: List<InstanceMirror> get metadata {
Previously this would always answer an empty list, even if there was metadata.

https://codereview.chromium.org/19235015/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:1063: List<InstanceMirror> get metadata {
Previously this raised a fatal, non-meaningful error.

[rmacnak, 2013-07-16 21:52:59]

The API version of metadata was the last user of VMReference.

[ahe, 2013-07-17 13:03:39]

DBC

https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
runtime/lib/mirrors_impl.dart:569: List<InstanceMirror> get metadata =>
_metadata(_reflectee).map(reflect).toList();
Long line.

https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
runtime/lib/mirrors_impl.dart:832: List<InstanceMirror> get metadata =>
_metadata(_reflectee).map(reflect).toList();
Long line.

[rmacnak, 2013-07-17 17:44:12]

On 2013/07/17 13:03:39, ahe wrote:
> DBC
> 
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
> runtime/lib/mirrors_impl.dart:569: List<InstanceMirror> get metadata =>
> _metadata(_reflectee).map(reflect).toList();
> Long line.
> 
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
> runtime/lib/mirrors_impl.dart:832: List<InstanceMirror> get metadata =>
> _metadata(_reflectee).map(reflect).toList();
> Long line.

Got 'em.

[rmacnak, 2013-07-17 20:19:37]

DI benchmark
Base:   150 ms
Change: 138 ms

Minor improvement from not managing the VMReferences.

On 2013/07/17 17:44:12, Ryan Macnak wrote:
> On 2013/07/17 13:03:39, ahe wrote:
> > DBC
> > 
> >
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.dart
> > File runtime/lib/mirrors_impl.dart (right):
> > 
> >
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
> > runtime/lib/mirrors_impl.dart:569: List<InstanceMirror> get metadata =>
> > _metadata(_reflectee).map(reflect).toList();
> > Long line.
> > 
> >
>
https://codereview.chromium.org/19235015/diff/6001/runtime/lib/mirrors_impl.d...
> > runtime/lib/mirrors_impl.dart:832: List<InstanceMirror> get metadata =>
> > _metadata(_reflectee).map(reflect).toList();
> > Long line.
> 
> Got 'em.

[siva, 2013-07-17 21:16:50]

lgtm

[rmacnak, 2013-07-17 21:50:58]

Committed patchset #3 manually as r25126 (presubmit successful).