Initial NOOP VM Service

Command line parameter check
VM Service isolate startup and shutdown

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25076

[siva, 2013-07-15 21:40:16]

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/main.cc#newcode70
runtime/bin/main.cc:70: // VM Service options
missing "."

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice/vmse...
File runtime/bin/vmservice/vmservice.dart (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice/vmse...
runtime/bin/vmservice/vmservice.dart:12: import 'dart:typed_data';
not sure if the dart style is to list these imports alphabetically?

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:55: monitor_ = new dart::Monitor();
ASSERT(monitor_ != NULL);

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:261: ASSERT(server_port >= 0);
This code needs a 
       MonitorLocker ml(monitor_);
somewhere here as it seems to do a Notify()

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:335: }
Where is this method used? Can we add it when it is used?

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl.h
File runtime/bin/vmservice_impl.h (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.h:22: static Dart_Port get_port();
why get_port() and not just port() ?

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.h:50: void Dart_VmServiceShutdownCallback();
I don't see an reference to this methods, where is it used?

[Cutch, 2013-07-15 21:58:38]

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/main.cc#newcode70
runtime/bin/main.cc:70: // VM Service options
On 2013/07/15 21:40:16, siva wrote:
> missing "."

Done.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice/vmse...
File runtime/bin/vmservice/vmservice.dart (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice/vmse...
runtime/bin/vmservice/vmservice.dart:12: import 'dart:typed_data';
On 2013/07/15 21:40:16, siva wrote:
> not sure if the dart style is to list these imports alphabetically?

It's not but I like it. Done.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:55: monitor_ = new dart::Monitor();
On 2013/07/15 21:40:16, siva wrote:
> ASSERT(monitor_ != NULL);

Done.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:261: ASSERT(server_port >= 0);
On 2013/07/15 21:40:16, siva wrote:
> This code needs a 
>        MonitorLocker ml(monitor_);
> somewhere here as it seems to do a Notify()

Done. Thanks.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.cc:335: }
On 2013/07/15 21:40:16, siva wrote:
> Where is this method used? Can we add it when it is used?

Done.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl.h
File runtime/bin/vmservice_impl.h (right):

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.h:22: static Dart_Port get_port();
On 2013/07/15 21:40:16, siva wrote:
> why get_port() and not just port() ?

Done.

https://codereview.chromium.org/19231005/diff/5001/runtime/bin/vmservice_impl...
runtime/bin/vmservice_impl.h:50: void Dart_VmServiceShutdownCallback();
On 2013/07/15 21:40:16, siva wrote:
> I don't see an reference to this methods, where is it used?

It's not right now. I've removed it for now.

[siva, 2013-07-16 00:00:04]

LGTM once the lock across Dart_RunLoop is fixed.

https://codereview.chromium.org/19231005/diff/13001/runtime/bin/vmservice_imp...
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/19231005/diff/13001/runtime/bin/vmservice_imp...
runtime/bin/vmservice_impl.cc:259: ASSERT(isolate_ == NULL);
I think you would have to close the MonitorLocker scope before
invoking Dart_Runloop as that guy blocks ans we don't want to be holding the
lock while blocking.

{

https://codereview.chromium.org/19231005/diff/13001/runtime/bin/vmservice_imp...
runtime/bin/vmservice_impl.cc:277: monitor_->Notify();
}

[Cutch, 2013-07-16 22:18:00]

Committed patchset #5 manually as r25076 (presubmit successful).