Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1922883004: Fix more strong-mode warnings. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more strong-mode warnings. I'm not sure how I missed these the first time. R=rnystrom@google.com Committed: https://github.com/dart-lang/http/commit/736cbb286cdf32ec40f43e8645d69a37dfb9e8cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/http.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M lib/src/multipart_file.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 8 months ago (2016-04-26 21:47:57 UTC) #1
Bob Nystrom
lgtm
4 years, 8 months ago (2016-04-26 22:24:43 UTC) #2
nweiz
4 years, 8 months ago (2016-04-26 22:52:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
736cbb286cdf32ec40f43e8645d69a37dfb9e8cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698