Issue 19223002: Always try to inline certain core library functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19223002: Always try to inline certain core library functions. (Closed)

Created:
7 years, 5 months ago by Florian Schneider

Modified:
7 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Always try to inline certain core library functions. Inlining moveNext and get:iterator enables the iterator object for allocation sinking. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25057

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -7 lines)			Patch
M	runtime/vm/flow_graph_inliner.cc	View	6 chunks	+13 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+24 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

srdjan

LGTM. Once you have moved the 'inlining' in the flow graph optimizer into the inliner, ...

7 years, 5 months ago (2013-07-16 16:17:09 UTC) #2

Florian Schneider

7 years, 5 months ago (2013-07-16 16:45:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25057 (presubmit successful).