Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1920433002: Create tar files in a cross-platform format. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create tar files in a cross-platform format. This passes --format=ustar to the tar process on Linux and OS X, which should prevent user-specific configuration from causing it to use the PAX format which is incompatible with 7zip on Windows. Closes #1411 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b191229fe06278d961c506c15dade1f122980d6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M lib/src/io.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 8 months ago (2016-04-22 18:41:01 UTC) #2
Bob Nystrom
lgtm
4 years, 8 months ago (2016-04-22 19:44:59 UTC) #3
nweiz
4 years, 8 months ago (2016-04-22 21:00:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b191229fe06278d961c506c15dade1f122980d6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698