Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Issue 1918933002: Fix for default filter (#228). (Closed)

Created:
4 years, 8 months ago by pquitslund
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for default filter (#228). The rub is that when I added awareness of filters to max error calculation, I forgot to account for the case where there was none set. This should address that, with a test added. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/linter/commit/96099d04550efc4d3ea9c0c48d70338c6c2891d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M bin/linter.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M test/integration_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pquitslund
4 years, 8 months ago (2016-04-25 16:39:50 UTC) #3
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-25 17:34:10 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as 96099d04550efc4d3ea9c0c48d70338c6c2891d4 (presubmit successful).
4 years, 8 months ago (2016-04-25 17:55:04 UTC) #6
Alexei D
4 years, 8 months ago (2016-04-25 18:29:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698