Issue 19180002: A dart int literal is a dart2js' int unless it will become NaN or infinity.

Issue 19180002: A dart int literal is a dart2js' int unless it will become NaN or infinity. (Closed)

Created:
7 years, 5 months ago by ngeoffray

Modified:
7 years, 5 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

A dart int literal is a dart2js' int unless it will become NaN or infinity. R=floitsch@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25007

Patch Set 5 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -9 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart	View	1 2 3	1 chunk	+13 lines, -9 lines	0 comments	Download
A	tests/compiler/dart2js_extra/constant_javascript_semantics4_test.dart	View	1 2 3 4	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart File sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart (right): https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart#newcode184 sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart:184: int absValue = value.abs(); Why do you need ...

7 years, 5 months ago (2013-07-15 13:25:50 UTC) #2

ngeoffray

Thanks Florian. PTAL. https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart File sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart (right): https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart#newcode184 sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart:184: int absValue = value.abs(); On 2013/07/15 ...

7 years, 5 months ago (2013-07-15 13:49:27 UTC) #3

karlklose

LGTM. https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart File sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart (right): https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart#newcode180 sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart:180: * Returns true if the given [value] will ...

7 years, 5 months ago (2013-07-15 13:52:08 UTC) #4

ngeoffray

Thanks Karl https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart File sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart (right): https://codereview.chromium.org/19180002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart#newcode180 sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart:180: * Returns true if the given [value] ...

7 years, 5 months ago (2013-07-15 13:53:38 UTC) #5

ngeoffray

Committed patchset #5 manually as r25007 (presubmit successful).

7 years, 5 months ago (2013-07-15 14:48:05 UTC) #7

ngeoffray

7 years, 5 months ago (2013-07-15 14:54:27 UTC) #8

Message was sent while issue was closed.

On 2013/07/15 14:48:05, ngeoffray wrote:
> Committed patchset #5 manually as r25007 (presubmit successful).

As discussed with Florian, also added a test that we deal with -0.0 correctly.

Expand Messages | Collapse Messages