Issue 19170002: Add regression test for bugfix in r24908

Issue 19170002: Add regression test for bugfix in r24908 (Closed)

Created:
7 years, 5 months ago by kustermann

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add regression test for bugfix in r24908 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=24998

Patch Set 2 : #

Total comments: 4

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	A +	tests/language/closures_initializer2_test.dart	View	1	2 chunks	+5 lines, -10 lines	4 comments	Download
	M	tests/language/language.status	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! thanks https://codereview.chromium.org/19170002/diff/2001/tests/language/closures_initializer2_test.dart File tests/language/closures_initializer2_test.dart (right): https://codereview.chromium.org/19170002/diff/2001/tests/language/closures_initializer2_test.dart#newcode17 tests/language/closures_initializer2_test.dart:17: for (var i=0; i<int.parse("1"); i++) { spaces ...

7 years, 5 months ago (2013-07-15 10:11:54 UTC) #2

kustermann

Committed patchset #2 manually as r24998 (presubmit successful).

7 years, 5 months ago (2013-07-15 10:26:15 UTC) #3

kustermann

7 years, 5 months ago (2013-07-15 10:26:25 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/19170002/diff/2001/tests/language/closures_in...
File tests/language/closures_initializer2_test.dart (right):

https://codereview.chromium.org/19170002/diff/2001/tests/language/closures_in...
tests/language/closures_initializer2_test.dart:17: for (var i=0;
i<int.parse("1"); i++) {
On 2013/07/15 10:11:54, ngeoffray wrote:
> Does the loop matter?
Yes it does. Because then it will inline 'expect' and trigger the bug.

https://codereview.chromium.org/19170002/diff/2001/tests/language/closures_in...
tests/language/closures_initializer2_test.dart:17: for (var i=0;
i<int.parse("1"); i++) {
On 2013/07/15 10:11:54, ngeoffray wrote:
> spaces around '=' and '<'.

Done.

Expand Messages | Collapse Messages