Issue 191253003: Include source map URLs in the generated JS.

Issue 191253003: Include source map URLs in the generated JS. (Closed)

Created:
6 years, 9 months ago by Bob Nystrom

Modified:
6 years, 8 months ago

Reviewers:
nweiz, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Include source map URLs in the generated JS. BUG=https://code.google.com/p/dart/issues/detail?id=15563 RELNOTE=Include source map URLs in JS output from pub build/serve. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=33465

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revise. #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/dart.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	A	sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart	View		1 chunk	+38 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/191253003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart File sdk/lib/_internal/pub/lib/src/dart.dart (right): https://codereview.chromium.org/191253003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart#newcode79 sdk/lib/_internal/pub/lib/src/dart.dart:79: var sourceUrl = path.toUri(entrypoint).toString(); Nit: [toString] here isn't ...

6 years, 9 months ago (2014-03-07 22:55:09 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r33465 (presubmit successful).

6 years, 9 months ago (2014-03-07 23:37:19 UTC) #3

Bob Nystrom

https://codereview.chromium.org/191253003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart File sdk/lib/_internal/pub/lib/src/dart.dart (right): https://codereview.chromium.org/191253003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart#newcode79 sdk/lib/_internal/pub/lib/src/dart.dart:79: var sourceUrl = path.toUri(entrypoint).toString(); On 2014/03/07 22:55:10, nweiz wrote: ...

6 years, 9 months ago (2014-03-07 23:37:52 UTC) #4

floitsch

DBC. https://codereview.chromium.org/191253003/diff/20001/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart File sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart (right): https://codereview.chromium.org/191253003/diff/20001/sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart#newcode31 sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart:31: contains("@ sourceMappingURL=main.dart.js.map") Don't look for this line. There ...

6 years, 9 months ago (2014-03-11 12:51:00 UTC) #5

Bob Nystrom

6 years, 8 months ago (2014-04-03 21:36:06 UTC) #6

Message was sent while issue was closed.

Oops, forgot to send this out.

https://codereview.chromium.org/191253003/diff/20001/sdk/lib/_internal/pub/te...
File
sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart
(right):

https://codereview.chromium.org/191253003/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/transformer/dart2js/includes_source_map_urls_test.dart:31:
contains("@ sourceMappingURL=main.dart.js.map")
On 2014/03/11 12:51:01, floitsch wrote:
> Don't look for this line.
> There is an open bug (issue 11914) to remove it. I expect it to be gone soon.

Thanks, I'll take this out in a separate patch.

Expand Messages | Collapse Messages