Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912273003: Make the package strong-mode clean. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/convert.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/hex/decoder.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M lib/src/hex/encoder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/percent/decoder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/percent/encoder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/accumulator_sink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/byte_accumulator_sink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hex_test.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M test/percent_test.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M test/string_accumulator_sink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nweiz
4 years, 8 months ago (2016-04-22 23:27:54 UTC) #1
nweiz
Sending to rnystrom since lrn is on leave.
4 years, 8 months ago (2016-04-26 22:55:35 UTC) #3
kevmoo
DBC https://codereview.chromium.org/1912273003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1912273003/diff/1/pubspec.yaml#newcode8 pubspec.yaml:8: sdk: '>=1.16.0-dev.5.0 <2.0.0' Can be 1.16 – we're ...
4 years, 8 months ago (2016-04-26 23:03:41 UTC) #5
Bob Nystrom
lgtm
4 years, 8 months ago (2016-04-26 23:53:29 UTC) #6
nweiz
Code review changes
4 years, 8 months ago (2016-04-27 00:12:53 UTC) #7
nweiz
https://codereview.chromium.org/1912273003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1912273003/diff/1/pubspec.yaml#newcode8 pubspec.yaml:8: sdk: '>=1.16.0-dev.5.0 <2.0.0' On 2016/04/26 23:03:41, kevmoo wrote: > ...
4 years, 8 months ago (2016-04-27 00:12:58 UTC) #8
nweiz
4 years, 8 months ago (2016-04-27 00:13:07 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b82b3fb68396f13022017cd705d5906be43fc60a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698